search

osrf / docker_images

A repository to hold definitions of docker images maintained by OSRF
Apache License 2.0
578 stars 172 forks source link

[ros2] Stop installing argcomplete from pip ? #642

Closed mikaelarguedas closed 1 year ago

mikaelarguedas commented 2 years ago

Follow-up of https://github.com/osrf/docker_images/pull/641#discussion_r986988546

mikaelarguedas commented 1 year ago

Looking a bit more into this, ros2cli uses some options of argcomplete that are not available on focal and jammy: https://github.com/ros2/ros2cli/blob/f46fa80c5bffe95b45fbba2e5cda724f3e4e8cce/ros2run/ros2run/command/run.py#L37 Which were introduced only in version 1.9.0 https://github.com/kislyuk/argcomplete/blob/develop/Changes.rst#changes-for-v190-2017-08-23

ros2cli wouldnt crash without it but some features would be lost.

Available versions in ubuntu:

 python3-argcomplete | 0.8.1-1ubuntu2   | xenial/universe  | all
 python3-argcomplete | 1.8.1-1ubuntu1   | bionic/universe  | all
 python3-argcomplete | 1.8.1-1.3ubuntu1 | focal/universe   | all
 python3-argcomplete | 1.8.1-1.5        | jammy/universe   | all
 python3-argcomplete | 2.0.0-1ubuntu1   | kinetic/universe | all
 python3-argcomplete | 2.0.0-1ubuntu1   | lunar/universe   | all

So none of the supported ubuntu version has a high enough version to satisfy our needs. I'll close this for now as it can't be adressed before a long time