search

osrf / docker_images

A repository to hold definitions of docker images maintained by OSRF
Apache License 2.0
577 stars 172 forks source link

[ros2][devel/nightly] add some missing pytest dependencies #747

Closed mikaelarguedas closed 6 months ago

mikaelarguedas commented 6 months ago

Otherwise some jobs based on ros2:devel fail, e.g. if you try to generate coverage for a python package

I took the set of pytest package from the ROS 2 CI: https://github.com/ros2/ci/blob/3435d04acf17872b07861e81265bc34d7ef40c72/linux_docker_resources/Dockerfile#L120-L125

mikaelarguedas commented 6 months ago

@nuclearsandwich @clalancette not sure if this is the set of packages users need to test packages with pytest ? or if some are not useful for end users and that's why they are not mentionned in the installation instructions ?

clalancette commented 6 months ago

@nuclearsandwich @clalancette not sure if this is the set of packages users need to test packages with pytest ? or if some are not useful for end users and that's why they are not mentionned in the installation instructions ?

That seems like a reasonable set.

They aren't mentioned in the installation instructions because they are only useful if you are running tests, i.e. a "debug"-style installation. So to try to keep dependencies smaller, we don't have them.

But you can definitely argue that they should be there for a complete set. If you'd like to open a PR to the documentation to add them, I'd be OK with that.