osrf / docker_images

A repository to hold definitions of docker images maintained by OSRF
Apache License 2.0
577 stars 172 forks source link

Add ROS_SYNC_DATE to dockerfile busting cache for each sync #775

Closed mikaelarguedas closed 3 days ago

mikaelarguedas commented 3 weeks ago

Update generated dockerfiles based on https://github.com/osrf/docker_templates/pull/110

Wil solve #112 as the dockerfiles will be outdated and regenerated at each sync.

ruffsl commented 3 weeks ago

Related discussion: https://github.com/osrf/docker_images/issues/753#issuecomment-2151415286

mikaelarguedas commented 3 weeks ago

@nuclearsandwich @tfoote what do you think about this approach ? Some assumptions are made here:

How do you feel about adding a new environment variable that is not provided by ros_environment ? Any feedback on the ROS_SYNC_DATE variable naming ?

mikaelarguedas commented 3 days ago

upstream PR: https://github.com/docker-library/official-images/pull/17960