Collada files do not follow collada specification, id attributes are not unique

osrf / drcsim

Repository for the DRC project.

16 stars 6 forks source link

Collada files do not follow collada specification, id attributes are not unique #360

Closed osrf-migration closed 10 years ago

osrf-migration commented 11 years ago

Original report (archived issue) by Nathan Mertins (Bitbucket: nmertins).

The original report had attachments: meshes_v3.zip

According to the collada specification (http://www.khronos.org/files/collada_schema_1_4) id attributes are unique within the document

The id attribute is a text string containing the unique identifier of this element. This value must be unique within the instance document. Optional attribute. Our collada importer assumes this behavior holds and cannot load the models if this is not the case. We changed the DAE files to correspond to the spec and they work fine then. I've attached the changed files.

osrf-migration commented 11 years ago

Original comment by Nathan Mertins (Bitbucket: nmertins).

set attachment to "meshes_v3_v2.zip"

There were also some inconsistencies with scaling and translations in some of the collada files (pelvis and lower legs) resulting in the models being out of place. This was an issue previously and is described in greater detail here https://osrf-migration.github.io/drcsim-gh-pages/#!/osrf/drcsim/issues/275/scale-incorrect-in-atlasurdf-files. (#275) I've attached another zip including these changes.

osrf-migration commented 11 years ago

Original comment by Stefan Kohlbrecher (Bitbucket: Stefan_Kohlbrecher).

This potentially also fixes #358.

osrf-migration commented 11 years ago

Original comment by John Hsu (Bitbucket: hsu, GitHub: hsu).

It looks like meshes_v3_v2.zip expands to the same set of files as meshes_v3.zip. Is that expected?

osrf-migration commented 11 years ago

Original comment by Nathan Mertins (Bitbucket: nmertins).

Yes, meshes_v3_v2.zip is meant to replace meshes_v3.zip.

osrf-migration commented 11 years ago

Original comment by Stefan Kohlbrecher (Bitbucket: Stefan_Kohlbrecher).

I think John is referring to the fact that the contents of both archives are completely identical (i.e. you probably accidentally did not include the files with the transformation/scaling fixes).

osrf-migration commented 11 years ago

Original comment by Nathan Mertins (Bitbucket: nmertins).

set attachment to "meshes_v3.zip"

Updated .zip to contain collada files with proper scaling and transforms.

osrf-migration commented 11 years ago

Original comment by Nathan Mertins (Bitbucket: nmertins).

I see what you mean. It appears I zipped the wrong directory. I've removed the other .zip files and uploaded the fixed version. Sorry for the confusion.

osrf-migration commented 11 years ago

Original comment by John Hoare (Bitbucket: jhoare).

Issue #358 was marked as a duplicate of this issue.

osrf-migration commented 11 years ago

Original comment by John Hoare (Bitbucket: jhoare).

I can confirm the second meshes_v3.zip fixes #358

osrf-migration commented 11 years ago

Original comment by John Hsu (Bitbucket: hsu, GitHub: hsu).

Thanks for the fixes. Please review pull request #384.

osrf-migration commented 10 years ago

Original comment by Steve Peters (Bitbucket: Steven Peters, GitHub: scpeters).

Issue #364 was marked as a duplicate of this issue.

osrf-migration commented 10 years ago

Original comment by John Hsu (Bitbucket: hsu, GitHub: hsu).

changed state from "new" to "resolved"

looks like the id-uniqueness problem is resolved.