osrf / drcsim

Repository for the DRC project.
16 stars 6 forks source link

fix standalone model generator dependency #420

Closed osrf-migration closed 10 years ago

osrf-migration commented 10 years ago

Original report (archived issue) by John Hsu (Bitbucket: hsu, GitHub: hsu).


Changing atlas_description/urdf/* does not trigger standalone model generator to regenerate affected models.

osrf-migration commented 10 years ago

Original comment by Nate Koenig (Bitbucket: Nathan Koenig).


osrf-migration commented 10 years ago

Original comment by John Hsu (Bitbucket: hsu, GitHub: hsu).


to pull request once bitbucket outage is fixed...

diff -r 0d6f86bff85b902717ff2cd804338b15e4fcb1b1 tools/URDF_helpers.cmake
--- a/tools/URDF_helpers.cmake  Tue Sep 16 20:13:50 2014 -0700
+++ b/tools/URDF_helpers.cmake  Tue Sep 16 20:14:06 2014 -0700
@@ -40,6 +40,5 @@
                          DEPENDS ${CMAKE_CURRENT_SOURCE_DIR}/robots/${xacro})
     endif()
     add_custom_target(${urdf}_gen ALL DEPENDS ${CMAKE_CURRENT_BINARY_DIR}/${standalone_name}/${base}/${urdf})
-    add_dependencies(${urdf}_gen ${CMAKE_CURRENT_SOURCE_DIR}/robots/${xacro})
   endforeach()
 endmacro()
osrf-migration commented 10 years ago

Original comment by John Hsu (Bitbucket: hsu, GitHub: hsu).


fix issue #420, make compile-time generated standalone model depend on xacro

→ \<\<cset 0d6f86bff85b902717ff2cd804338b15e4fcb1b1>>

osrf-migration commented 10 years ago

Original comment by John Hsu (Bitbucket: hsu, GitHub: hsu).


pull request #461

osrf-migration commented 10 years ago

Original comment by John Hsu (Bitbucket: hsu, GitHub: hsu).


undo auto-close, pull request #461 has a partial fix, but insufficient.

osrf-migration commented 10 years ago

Original comment by John Hsu (Bitbucket: hsu, GitHub: hsu).


Merged in issue_420 (pull request #461)

fix issue #420, make compile-time generated standalone model depend on xacro

→ \<\<cset 861e802c76d11a2c2d1798f44cb97008145b598a>>