Multisense and v5 Model

osrf / drcsim

Repository for the DRC project.

16 stars 6 forks source link

Multisense and v5 Model #491

Closed osrf-migration closed 9 years ago

osrf-migration commented 9 years ago

Original report (archived issue) by Mathew DeDonato (Bitbucket: mdedonato NA).

The multisense is not aligned correctly in the v5 model

osrf-migration commented 9 years ago

Original comment by Nate Koenig (Bitbucket: Nathan Koenig).

Do you have more information? We don't have an Atlas, so any little bits will help.

osrf-migration commented 9 years ago

Original comment by Nate Koenig (Bitbucket: Nathan Koenig).

@BillBlank any ideas?

osrf-migration commented 9 years ago

Original comment by Mathew DeDonato (Bitbucket: mdedonato NA).

In v5 simple shapes the head joint has an origin of the following

This causes the model to visibly be off from the model. If you assume the v4 simple shapes has the correct joint setup for the sensor head, you need to update this line to

I am not sure why the offsets were in there.

osrf-migration commented 9 years ago

Original comment by Bill Blank (Bitbucket: BillBlank).

The neck_ry offset file changes were introduced Tue 25, just a few days after after the first AtlasSimInterface3.0.0 was shipped. John Hsu was focusing on resolving discrepancies between collision and visuals. My best guess is that change was necessary to align the multisense with those visuals, but more accurate visuals were then delivered, and that offset was never removed.

osrf-migration commented 9 years ago

Original comment by Steve Peters (Bitbucket: Steven Peters, GitHub: scpeters).

How does a486c18552ad4b69a91a828940b8bf6f27901fcc (branch issue_491) look?

osrf-migration commented 9 years ago

Original comment by Steve Peters (Bitbucket: Steven Peters, GitHub: scpeters).

I'll make a pull request if you approve.

osrf-migration commented 9 years ago

Original comment by Bill Blank (Bitbucket: BillBlank).

That looks better, thanks.

osrf-migration commented 9 years ago

Original comment by Steve Peters (Bitbucket: Steven Peters, GitHub: scpeters).

pull request #534

osrf-migration commented 9 years ago

Original comment by Steve Peters (Bitbucket: Steven Peters, GitHub: scpeters).

set assignee_account_id to "557058:5de38267-b118-494c-aa76-4fab35448816"
set assignee to "scpeters (Bitbucket: scpeters, GitHub: scpeters)"

osrf-migration commented 9 years ago

Original comment by Steve Peters (Bitbucket: Steven Peters, GitHub: scpeters).

changed state from "new" to "open"

osrf-migration commented 9 years ago

Original comment by Steve Peters (Bitbucket: Steven Peters, GitHub: scpeters).

changed state from "open" to "resolved"

pull request #534