search

osrf / gazebo_tutorials

Tutorials for gazebo
http://gazebosim.org/tutorials
146 stars 71 forks source link

Fix missing ; in GZ_REGISTER_WORLD_PLUGIN #109

Closed efernandez closed 4 years ago

efernandez commented 4 years ago

The error is also in the big code snippet, but that's not in this file. Not sure if that's auto-generated. :thinking:

chapulina commented 4 years ago

Thanks for the PR. Is that required though? The code is currently working, right? Looking at other plugins it looks like we never add a ;.

efernandez commented 4 years ago

@chapulina TBH I was helping a friend who was doing the tutorial, and I believe it was failing to compile for him because of that. I must say I was helping him remotely, so it could be that you're right and the ; isn't really require.

Feel free to close if you're sure it's not required. Otherwise, I could find some time to do a quick try.

chapulina commented 4 years ago

Got it. I'll close it for now, but feel free to reopen if you can describe how to reproduce the issue :wink: