search

osrf / homebrew-simulation

Homebrew tap for osrf simulation software
Apache License 2.0
56 stars 75 forks source link

gz-cmake4 4.0.0~pre1 #2732

Closed osrfbuild closed 2 months ago

scpeters commented 2 months ago

build bottle

azeey commented 2 months ago

@scpeters if we build bottles here, does this mean that downstream libraries on main branches wil start using it instead of building from source? On Ubuntu, they will be using nightlies, on Windows, they'll be building from source, so I want to make sure we're not introducing a descrepancy.

scpeters commented 2 months ago

this PR changes the url from a git branch to a prerelease tarball, so if we merge it then it will no longer build from the GitHub branch, regardless of whether it's bottled or not

so if we want to keep building from git branches instead of prerelease tarballs, then I would suggest that we close these prerelease pull requests until we are ready to build from a tarball

scpeters commented 2 months ago

(also, your comment included the magic phrase that matches our regular expression in brew_release.dsl, so it triggered an additional bottle builder job. it caused no harm in this case, just an FYI)

azeey commented 2 months ago

lol, I wondered why there' was another build (I almost did that again).

so if we want to keep building from git branches instead of prerelease tarballs, then I would suggest that we close these prerelease pull requests until we are ready to build from a tarball

Yeah, let's do that. We can build all the bottles together on Wednesday.