Updating package maintainers

osrf / mbari_wec_gz

Simulation of wave energy harvesting buoy

Apache License 2.0

18 stars 2 forks source link

Updating package maintainers #141

Closed quarkytale closed 1 year ago

quarkytale commented 1 year ago

Apologies if I missed or miscredited anyone 🙏

Added maintainers and authors in alphabetical order, depending on contributors of each package (or rather everyone should be added in every package?).

Notes:

Need Louise's and Joan's current/preferred email
Added Rob in buoy_gazebo to credit for mbari_wec

quarkytale commented 1 year ago

Not sure why tests are failing, cannot reproduce locally.

quarkytale commented 1 year ago

SC Commands test keeps timing out here which seems unrelated to the changes in this PR. @andermi any suggestions? Test #37: launch_sc_commands_ros_feedback.launch.py ...***Timeout 900.11 sec

andermi commented 1 year ago

Increase the timeouts. It’s a long test on a very slow machine. I’ve had to increase the timeouts a few times now. I think their machines are getting even slower…

quarkytale commented 1 year ago

@andermi set the timeouts to nothing less than 1000 sec works well, is it okay if I get this in and further refinements can be done in a separate PR if required?

andermi commented 1 year ago

Yep fine with me! Merge away!