osrf / mbari_wec_gz

Simulation of wave energy harvesting buoy
Apache License 2.0
18 stars 2 forks source link

CI failing to detect 'ros-humble-actuator-msgs' #142

Closed quarkytale closed 1 year ago

quarkytale commented 1 year ago

All PRs on this repo are stuck on this error, even seeing the same while building the docker image on mbari_wec.

  apt: command [apt-get install -y ros-humble-actuator-msgs] failed
  apt: Failed to detect successful installation of [ros-humble-actuator-msgs]
Error: Process completed with exit code 1.
andermi commented 1 year ago

From slack:

fresh install for @hamilton8415 failed on actuator_msgs in ros_gz_bridge

Starting >>> ros_gz_bridge
--- stderr: ros_gz_bridge
CMake Error at CMakeLists.txt:62 (find_package):
  By not providing "Findactuator_msgs.cmake" in CMAKE_MODULE_PATH this
  project has asked CMake to find a package configuration file provided by
  "actuator_msgs", but CMake did not find one.

  Could not find a package configuration file provided by "actuator_msgs"
  with any of the following names:

    actuator_msgsConfig.cmake
    actuator_msgs-config.cmake

  Add the installation prefix of "actuator_msgs" to CMAKE_PREFIX_PATH or set
  "actuator_msgs_DIR" to a directory containing one of the above files.  If
  "actuator_msgs" provides a separate development package or SDK, be sure it
  has been installed.

---
Failed   <<< ros_gz_bridge [0.65s, exited with code 1]

actuator_msgs was recently added to ros_gz_bridge... looking at the git log:

commit b9694c14abd144f2c6773e3b3cafffcdcb8f85e0
Author: Benjamin Perseghetti <bperseghetti@rudislabs.com>
Date:   Tue Apr 25 16:56:52 2023 -0400

    Add actuator_msgs to bridge. (#378)

    Signed-off-by: Benjamin Perseghetti <bperseghetti@rudislabs.com>

reverting back to 7c62a1ce3cfb4eb3b54e1cfd092c9b63a9d5f255 should fix the problem

same author on the acutator_msgs repo: https://github.com/rudislabs/actuator_msgs/tree/0.0.1 guessing he didn't get a debian in the bloom farm

here's his PR: https://github.com/gazebosim/ros_gz/pull/378

[#378 Add actuator_msgs to bridge.](https://github.com/gazebosim/ros_gz/pull/378)
:tada: New feature
Adds actuators message to the ROS side of the bridge allowing for control of most (all?) types of actuators in simulation.
[gazebosim/gz-sim#1952](https://github.com/gazebosim/gz-sim/pull/1952)  
[gazebosim/gz-sim#1953](https://github.com/gazebosim/gz-sim/pull/1953)  
[gazebosim/gz-sim#1954](https://github.com/gazebosim/gz-sim/pull/1954)
As seen in the Gazebo community meeting:  
https://vimeo.com/812911652#t=39m58s
Depends on release of: https://github.com/rudislabs/actuator_msgs
Checklist
☑︎ Signed all commits for DCO
☑︎ Added tests
Show more
Comments
3
<https://github.com/[gazebosim/ros_gz](https://github.com/gazebosim/ros_gz)|gazebosim/ros_gz>gazebosim/ros_gz | Mar 31st | Added by [GitHub](https://mbari.slack.com/services/B01UZK7GAF6)

his bloom is targeting rolling according to this: https://github.com/ros/rosdistro/pull/36796

[#36796 actuator_msgs: 0.0.1-2 in 'rolling/distribution.yaml' [bloom]](https://github.com/ros/rosdistro/pull/36796)
Increasing version of package(s) in repository actuator_msgs to 0.0.1-2:
• upstream repository: https://github.com/rudislabs/actuator_msgs.git
• release repository: https://github.com/ros2-gbp/actuator_msgs-release.git
• distro file: rolling/distribution.yaml
• bloom version: 0.11.2
• previous version for package: null
actuator_msgs
* Initial commit.
Show more
Labels
rolling
<https://github.com/[ros/rosdistro](https://github.com/ros/rosdistro)|ros/rosdistro>ros/rosdistro | Apr 11th | Added by [GitHub](https://mbari.slack.com/services/B01UZK7GAF6)

I guess it needs a port to humble? (edited)

quarkytale commented 1 year ago

I guess it needs a port to humble? (edited)

Seems like its already added, https://github.com/ros/rosdistro/pull/36795

andermi commented 1 year ago

well, somehow it didn't make it into apt after that

andermi commented 1 year ago

at the very least, we aren't using anything related to the actuator_msgs stuff so I'm fine reverting and freezing ros_gz for now. We can just tie that commit to our release

andermi commented 1 year ago

something like this: https://github.com/osrf/mbari_wec/pull/51

quarkytale commented 1 year ago

Adding ros-testing sources list fixes our build, this is a temporary fix till a Humble sync is out (by this week).

andermi commented 1 year ago

Please see my comment in #143

quarkytale commented 1 year ago

Tested this after Humble sync, apt install worked and could build the latest ros2 branch of ros_gz too!