search

osrf / mbari_wec_gz

Simulation of wave energy harvesting buoy
Apache License 2.0
18 stars 2 forks source link

Fix pbcmd terminate #147

Closed andermi closed 1 year ago

andermi commented 1 year ago

Needs https://github.com/osrf/mbari_wec_utils/pull/50 fixed the error:

terminate called without an active exception
Aborted (core dumped)

but still get a segfault every so often with all subcommands of pbcmd

quarkytale commented 1 year ago

Is this for the batch run seg fault issue?

andermi commented 1 year ago

This is to fix an issue with pbcmd not waiting for the request future before quitting and throwing an error. There is also an error that this does not fix which is a segfault in the dds library when pbcmd is closing but only happens about 1 in 10 times (doing up-arrow-enter) while the sim is running.

andermi commented 1 year ago

Hope I didn't sign my life away by approving.

at least it's not going into main yet ;)