search

osrf / mbari_wec_gz

Simulation of wave energy harvesting buoy
Apache License 2.0
18 stars 2 forks source link

Hamilton8415/ehpto switchlossfix #169

Closed hamilton8415 closed 11 months ago

hamilton8415 commented 11 months ago

This merge brings changes to the electro-hydraulic PTO plugin into main and includes a number of changes to improve the match between the plugins behavior and the bench-test measurements

andermi commented 11 months ago 
ros2 launch buoy_tests experiment_comparison_select.launch.py manual:=True test_inputdata_exp:='2022.12.21T15.44.24_VentedSpring.exp' test_inputdata_tst:='2022.12.21T15.44.24_VentedSpring.tst'
andermi commented 11 months ago

I didn't like how you have to specify both exp and tst... so, now I just have you enter the basename once and it will do the .exp and .tst for you

andermi commented 11 months ago

oops... I broke something stupid with the CI version of experiment_comparison. I'll fix it.

andermi commented 11 months ago

I think I found a much easier way to write the args... 🤦‍♂️

hamilton8415 commented 11 months ago

I never doubted you, I'll give it a run-through whenever it's set.

andermi commented 11 months ago

I still need to implement it. I'll let you know when it's done :)

andermi commented 11 months ago 
ros2 launch buoy_tests experiment_comparison_select.launch.py manual:=True test_inputdata:='2022.12.21T15.44.24_VentedSpring'

or, 

ros2 launch buoy_tests experiment_comparison_select.launch.py manual:=True test_inputdata:='2022.12.21T15.44.24_VentedSpring.exp'

or,

ros2 launch buoy_tests experiment_comparison_select.launch.py manual:=True test_inputdata:='/path/to/2022.12.21T15.44.24_VentedSpring.exp'

it will always look in buoy_tests/test_inputdata/ for the name of the test you specified... it will ignore your path. and it will also ignore the .exp and .tst file extensions

andermi commented 11 months ago

fixed the absement tests and added some comments for what I did in the _select launch file... The only test not passing is the experiment_comparison now. Need to approve the .tst I think

andermi commented 11 months ago

nice job remembering the CI hehe