search

osrf / osrf_testing_tools_cpp

Common testing tools for C++ which are used for testing in various OSRF projects.
Apache License 2.0
33 stars 29 forks source link

Bump googletest 1.8.0 -> 1.8.1 #36

Closed rotu closed 4 years ago

rotu commented 4 years ago

Fix build under clang 10 #35

wjwwood commented 4 years ago

CI:

rotu commented 4 years ago

Fixed spacing changes. CI fail seems to be from a linker error in FastRTPS.

wjwwood commented 4 years ago

Yeah, sorry we're working on that, it was a upstream change in fast-rtps.

Thanks for fixing up the whitespace.

rotu commented 4 years ago

I fixed up the tests and made https://github.com/colcon/colcon-cmake/pull/66 to fix the issues with colcon not reporting test details :-)

wjwwood commented 4 years ago

Still waiting on some stuff in CI to settle down before I re-test this.

rotu commented 4 years ago

@wjwwood Has CI settled down yet?

wjwwood commented 4 years ago

I don't know actually... I'll catch up on it today.

wjwwood commented 4 years ago

CI:

rotu commented 4 years ago

Hmm... What do you make of this? It looks very wrong:

[ERROR] [launch]: Caught exception in launch (see debug for traceback): package 'demo_nodes_py' found at '/home/jenkins-agent/workspace/ci_linux-aarch64/ws/install/demo_nodes_py', but libexec directory '/home/jenkins-agent/workspace/ci_linux-aarch64/ws/install/demo_nodes_py/lib/demo_nodes_py' does not exist

https://ci.ros2.org/job/ci_linux-aarch64/5066/consoleText

wjwwood commented 4 years ago

The test failures are due to this: https://github.com/ros2/build_cop/issues/266

wjwwood commented 4 years ago

@rotu unfortunately this is causing an issue with some of our nightly jobs that use ASan and TSan, so I'm going to revert it (that's our policy if it breaks a CI job).

I don't have the bandwidth to follow up and fix the problem however. I'll have to rely on someone else, maybe @rotu or someone else on the AWS side to investigate the issue (not sure if it is a problem with googletest or how we use ASan/TSan).