osrf / osrf_testing_tools_cpp

Common testing tools for C++ which are used for testing in various OSRF projects.
Apache License 2.0
33 stars 29 forks source link

Nightly ASan and TSan builds are failing to build osrf_testing_tools_cpp #37

Closed prajakta-gokhale closed 4 years ago

prajakta-gokhale commented 4 years ago

Hi, there have been failures in the nightly ASan and TSan builds due to a linker error caused while building this package. These failures started around the time https://github.com/osrf/osrf_testing_tools_cpp/pull/36 (gtest version bump) was merged.

All build details are in https://github.com/ros-tooling/aws-oncall/issues/83.

prajakta-gokhale commented 4 years ago

@wjwwood could you please take a look?

wjwwood commented 4 years ago

I reverted the pull request that seems to have caused the issue. I'll leave this issue to you as to whether you want to track the problem or close it.

prajakta-gokhale commented 4 years ago

Thank you! Merging the linked PR should close this.