Compatibility with binutils 2.34

osrf / osrf_testing_tools_cpp

Common testing tools for C++ which are used for testing in various OSRF projects.

Apache License 2.0

33 stars 29 forks source link

Closed mogenson closed 4 years ago

mogenson commented 4 years ago

Binutils 2.34 dropped a parameter from some macros. Check to see if macro is defined, if not define the appropriate macro interface. Change is noted here: https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;a=commitdiff;h=fd3619828e94a24a92cddec42cbc0ab33352eeb4

christophebedard commented 4 years ago

@wjwwood @jacobperron FYI

This isn't needed if backward is upgraded to 1.5, see https://github.com/bombela/backward-cpp/pull/165

Otherwise, it might be a good idea to get this small fix in for Foxy, since Focal has binutils 2.34: https://packages.ubuntu.com/focal/binutils

wjwwood commented 4 years ago

Thanks for the heads up @christophebedard, I'll look into upgrading backwards in our local source instead of this patch.

wjwwood commented 4 years ago

Closed in favor of #45.