osrf / osrf_testing_tools_cpp

Common testing tools for C++ which are used for testing in various OSRF projects.

Apache License 2.0

33 stars 29 forks source link

Closed audrow closed 3 years ago

audrow commented 3 years ago

This PR enables Wformat=2, Wconversion, Woverloaded-virtual, Wshadow, and Wnon-virtual-dtor in osrf_testing_tools_cpp.

audrow commented 3 years ago

audrow commented 3 years ago

~~Running different gtest versions to see if we can fix the warnings:~~

Edit: These CI runs are irrelevant because this package has its own copy of googletest (here), which uses v1.8.1 (ament/googletest uses v1.8.0).

audrow commented 3 years ago

Ah, this packages seems to be using its own internal version of gtest (v1.8.1).

audrow commented 3 years ago

3 out of 36 warnings remain on macOS after googletest was updated. They seem reasonable. I'll try to fix them and then rerun CI.

audrow commented 3 years ago

Here is another run of macOS's CI:

audrow commented 3 years ago

Here's a full run of CI (I reused macOS CI run from my previous comment):

audrow commented 3 years ago

61 is for the Windows warnings.

audrow commented 3 years ago

I've rebased on master now that #61 has been merged. Here's a new CI run:

audrow commented 3 years ago

audrow commented 3 years ago

@clalancette, I don't have permission to merge in this repo. Could you merge this in when you have a chance?