search

osrf / osrf_testing_tools_cpp

Common testing tools for C++ which are used for testing in various OSRF projects.
Apache License 2.0
33 stars 29 forks source link

Add googletest v1.10.0 #55

Closed audrow closed 3 years ago

audrow commented 3 years ago

This PR updates googletest to address warnings seen in https://github.com/osrf/osrf_testing_tools_cpp/pull/54.

clalancette commented 3 years ago

The change looks OK to me, but I'm suspicious that the PR job is failing. Not sure why that is.

audrow commented 3 years ago

I believe that there's a bug causing the wrong version of googletest to be used (when I select 1.10.0, it selects 1.7.0). I'll look into it.

-- googletest version '1.7.0' selected, of versions: '1.10.0'
-- building googletest from '/root/ros2_ws/src/osrf/osrf_testing_tools_cpp/osrf_testing_tools_cpp/vendor/google/googletest/release-1.7.0.tar.gz'...
audrow commented 3 years ago
audrow commented 3 years ago

@clalancette, would you merge it when you have a chance? I don't have permission to.