search

osrf / osrf_testing_tools_cpp

Common testing tools for C++ which are used for testing in various OSRF projects.
Apache License 2.0
33 stars 29 forks source link

Initial support for Apple M1 #62

Closed eboasson closed 3 years ago

eboasson commented 3 years ago

Signed-off-by: Erik Boasson eb@ilities.com

clalancette commented 3 years ago

It looks like this is being done in a slightly different way upstream: https://github.com/bombela/backward-cpp/pull/201

I think we should probably comment on that one and push to get it landed, and then update our vendored copy here.

eboasson commented 3 years ago

I've asked them

christophebedard commented 3 years ago

The upstream PR was merged: https://github.com/bombela/backward-cpp/pull/201.

@clalancette I know this will have to wait until a galactic branch is created, but how should the vendor copy be updated? We're currently using v1.5 (#45) + an additional fix (#54), but there is no newer release (>=v1.6). Should I just use the latest master commit or should I use the commit corresponding to https://github.com/bombela/backward-cpp/pull/201?

clalancette commented 3 years ago

@clalancette I know this will have to wait until a galactic branch is created, but how should the vendor copy be updated? We're currently using v1.5 (#45) + an additional fix (#54), but there is no newer release (>=v1.6). Should I just use the latest master commit or should I use the commit corresponding to bombela/backward-cpp#201?

I'd personally go with the latest master commit.

varunagrawal commented 3 years ago

Is there any movement planned on this? Galactic was released quite a while ago. 🙂

clalancette commented 3 years ago

Actually, this should just be closed in favor of #64, so I'll do that now.