search

osrf / osrf_testing_tools_cpp

Common testing tools for C++ which are used for testing in various OSRF projects.
Apache License 2.0
33 stars 29 forks source link

Upgrade to Google test 1.14.0 #84

Closed clalancette closed 7 months ago

clalancette commented 8 months ago

This matches the version that will be in Ubuntu 24.04, and should resolve some CMake warnings when building on that platform.

@marcoag please take a look at this and https://github.com/ament/googletest/pull/27 when you get a chance.

marcoag commented 8 months ago

I did a local build with no issues, LGTM.

Note: I can't review or mark the approval since I'm not assigned.

clalancette commented 8 months ago

CI:

clalancette commented 7 months ago

OK, I think I figured out the difference here. I think some of the code was trying to use std::variant, and some was trying to use mpark::variant. In the latest, I removed the mpark::variant; we don't need it anymore since we have C++17 everywhere. So I think this should fix the issue, I'll run another CI on it.

@wjwwood @marcoag I could use another review here.

clalancette commented 7 months ago

CI:

clalancette commented 7 months ago

I'm going to go ahead and merge this one since it was already approved. If there are any followups I'll deal with them separately.