search

osrf / rmf_core

Provides the centralized functions of RMF: scheduling, etc.
Apache License 2.0
102 stars 41 forks source link

Eliminate busy wait #254

Closed arjo129 closed 3 years ago

arjo129 commented 3 years ago

Eliminates the busy wait previously used in Transport by replacing it with a custom rclcpp::Executor .

mxgrey commented 3 years ago

@koonpeng would you be able to test this out on the web CI (without the transport_sleep parameter) to see if this also provides an acceptable solution to the busy waiting problem?

If these changes fix the problem then we could revert the changes done here.

koonpeng commented 3 years ago

It won't be straight forward as the CI uses a nightly build on master. We can revert the hack job changes as the CI is not using it actually.

arjo129 commented 3 years ago

I've reverted the changes of #253 .