search

osrf / rmf_demos

Demos to showcase the capabilities of RMF
Apache License 2.0
69 stars 38 forks source link

add dockerfile #194

Closed koonpeng closed 3 years ago

koonpeng commented 3 years ago

Submodules!?

The main controversy about this is the use of submodules, it has some advantages which makes them worthwhile.

  1. docker supports submodules, this allows docker images to be built directly from git with docker build https://github.com/osrf/rmf_demos.git
  2. allows reproducible builds

We do need to make sure the submodules are updated regularly, we can use automated workflows to do that.

Question

How often is rmf-rolling updated? We may not need this if its updated very fast.

Yadunund commented 3 years ago

@koonpeng, after the repo reorganization, will the submodule approach still be a suitable option given the increased number of repos to pull from? Regarding rmf-rolling, I believe the goal is to eventually have nightly builds. But as of now the changes for each package has to be bloomed manually.

koonpeng commented 3 years ago

What would the normal build steps be like when this is changed to multiple repos? I guess we need to clone all the sub-repos as well?

I think the standard practice for multi repo projects is to have a meta repo for docker.

Yadunund commented 3 years ago

What would the normal build steps be like when this is changed to multiple repos? I guess we need to clone all the sub-repos as well?

We would update the repos file and use vcs to import the various repos into the workspace.

I think the standard practice for multi repo projects is to have a meta repo for docker.

Noted on that. I guess it will take time for all the repos to be reorganized and in the meanwhile we can work with this dockerfile.