Server crash after client disconnect

[osrf-migration]

Original report (archived issue) by Stefan Glaser (Bitbucket: umscht).

---

The server crashes after I disconnect my client from it with the following message:

RCPServer::Send() Socket not found.
terminate called after throwing an instance of 'std::bad_alloc'
  what():  std::bad_alloc

To reproduce the problem, simply take the magma-protocol-tester from issue 12 (http://chaosscripting.net/files/magma-protocol-tester.zip), then:

1. start gazebo with robocup3ds plugin and run the magma-protocol-tester GUI
2. connect an agent ("connect" button)
3. initialize it ("Send init" button) (after that confirm that the agent shows up in the simulator)
4. hit the "disconnect" button

It seems like the server still tries to send messages to closed sockets, or doesn't handle the exception when the other side disconnects during a send-call.

[osrf-migration]

Original comment by Stefan Glaser (Bitbucket: umscht).

---

• Edited issue description

[osrf-migration]

Original comment by jasonzliang NA (Bitbucket: jasonzliang).

---

• set assignee_account_id to "557058:4f6d7230-9817-448e-8b0d-98cb3dd0821c"
• set assignee to "jasonzliang (Bitbucket: jasonzliang)"

[osrf-migration]

Original comment by jasonzliang NA (Bitbucket: jasonzliang).

---

I have added a fix here: https://osrf-migration.github.io/osrf-projects-gh-pages/#!/osrf/robocup3ds/pull-requests/43/fix-for-issue-14/diff

[osrf-migration]

Original comment by Stefan Glaser (Bitbucket: umscht).

---

Hi Jason,

I can confirm that your fix resolves this issue. I'm now able to disconnect properly without crashing the server.

Thanks for your effort!

[osrf-migration]

Original comment by jasonzliang NA (Bitbucket: jasonzliang).

---

• changed state from "new" to "resolved"

[osrf-migration]

Original comment by jasonzliang NA (Bitbucket: jasonzliang).

---

• changed state from "resolved" to "open"

Still need to merge pull request

[osrf-migration]

Original comment by Carlos Agüero (Bitbucket: caguero, GitHub: caguero).

---

• changed state from "open" to "resolved"

See pull request #43