Closed osrf-migration closed 8 years ago
osrf-migration
commented
8 years ago Original comment by Jens Fischer (Bitbucket: Gama11).
Looking through the source a bit, it looks like the there's already some way to configure several options, including "gamestate_secondsbeforekickoff". It would be nice if the different options and how they're passed to the plugin in the first place could be documented in the Readme.
osrf-migration
commented
8 years ago Original comment by Carlos Agüero (Bitbucket: caguero, GitHub: caguero).
The parameters are documented in the wiki.
As far as I understand there are two problems:
play after 5 seconds of an agent insertion. What is the expected behavior here?play mode and this shouldn't happen.osrf-migration
commented
8 years ago Original comment by Jens Fischer (Bitbucket: Gama11).
Wow, I didn't realize there was a Wiki. Perhaps a link to it in the Readme wouldn't hurt, for other people who are as blind as me. :)
rcssserver3d, apart from differences in phyiscs? See also #18.play in Gazebo, but it is in SimSpark.osrf-migration
commented
8 years ago Original comment by Carlos Agüero (Bitbucket: caguero, GitHub: caguero).
Added a link to the wiki in the readme.
I would say that the default behavior should be to behave as SimSpark unless there's a good reason for not to do it. I don't think there's a particular reason for introducing timed transitions from beforeKickOff to kickoff, so we can disable them.
osrf-migration
commented
8 years ago Original comment by Jens Fischer (Bitbucket: Gama11).
So, should that logic be removed entirely, along with the "gamestate_secondsbeforekickoff" setting, or just disabled by default, via a default value of -1 or similar?
osrf-migration
commented
8 years ago Original comment by Carlos Agüero (Bitbucket: caguero, GitHub: caguero).
We can keep the parameter as you're suggesting and add a default value of -1 that won't enable the timed transition. We have to make sure that we update the tests, as they will fail.
As for the agent insertion during playMode we added a check to prevent it. If this is a valid use case, we'll remove the check.
I'll submit a pull request with these changes to close this issue soon. Thanks for the comments!
osrf-migration
commented
8 years ago Original comment by Carlos Agüero (Bitbucket: caguero, GitHub: caguero).
See pull request #48, where the timed transition is disabled by default.
While testing, I disabled the extra check for being able to insert agents in play mode but the agent is catapulted in the air for a few seconds. I can insert it in the side of the field in a stable pose but probably that's not super useful. How important is to tackle this issue compared with the rest of open issues?
osrf-migration
commented
8 years ago osrf-migration
commented
8 years ago Original comment by Jens Fischer (Bitbucket: Gama11).
Not that important, #24 and #18 have a higher priority I think.
osrf-migration
commented
8 years ago Original comment by Carlos Agüero (Bitbucket: caguero, GitHub: caguero).
Merged in issue_21 (pull request #48)
Fix issue #21 partially
→ \<\<cset b4ef7947dae9bdeefcd49ab4d632b3268b714488>>
osrf-migration
commented
8 years ago Original comment by Jens Fischer (Bitbucket: Gama11).
Should this be marked as resolved yet, considering the PR only solved part of it?
osrf-migration
commented
8 years ago osrf-migration
commented
8 years ago osrf-migration
commented
8 years ago
Original report (archived issue) by Jens Fischer (Bitbucket: Gama11).
It seems like the gazebo plugin behaves differently from SimSpark in that the game is automatically started 5 seconds after a player is connected. This was quite counter-intuitive to me at first. It's annoying for testing since adding agents after the game has started is also not allowed.
It would be nice if this behavior was changed or if there was at least an option to turn it off.