osrf / robocup3ds

Gazebo support for the RoboCup 3D simulation league.
11 stars 2 forks source link

Agent actions are discarded between cycles #32

Closed osrf-migration closed 8 years ago

osrf-migration commented 8 years ago

Original report (archived issue) by Stefan Glaser (Bitbucket: umscht).


In SimSpark, when sending no joint effector message, the previous action of the joint keeps active. To reduce network overhead, we implemented in our agent code that if the effector value doesn't change for a joint, it will suppress sending the same value again.

When looking into the Robocup3dsPlugin class, I found a call to clear the map of effectors after they are applied (line 422). When removing this line, our agent moves more like we expect. Is there a reason why the map of effectors is cleared in each cycle?

osrf-migration commented 8 years ago

Original comment by Louise Poubel (Bitbucket: chapulina, GitHub: chapulina).


pull request #57

osrf-migration commented 8 years ago

Original comment by Louise Poubel (Bitbucket: chapulina, GitHub: chapulina).


Don't clear the effector map each cycle, fixes #32

→ \<\<cset 3d0e0d5dfc6b7f68caf5b69cbc92253918c7fe5c>>

osrf-migration commented 8 years ago

Original comment by Carlos Agüero (Bitbucket: caguero, GitHub: caguero).


Merged in Gama11/robocup3ds/issue_32 (pull request #57)

Don't clear the effector map each cycle, fixes #32

→ \<\<cset fba6d7ea89a321b1465d62eb1995a22e14348bbc>>