osrf / rocker

A tool to run docker containers with overlays and convenient options for things like GUIs etc.
Apache License 2.0
561 stars 73 forks source link

add cuda support to images #126

Closed tfoote closed 2 years ago

tfoote commented 3 years ago

Currently a draft proof of concept. This will be revised to be more generic. But this should help with visiblity.

codecov[bot] commented 3 years ago

Codecov Report

Merging #126 (21336f9) into master (4f9f6d7) will decrease coverage by 2.93%. The diff coverage is 31.57%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #126      +/-   ##
==========================================
- Coverage   82.72%   79.78%   -2.94%     
==========================================
  Files           7        7              
  Lines         625      663      +38     
==========================================
+ Hits          517      529      +12     
- Misses        108      134      +26     
Impacted Files Coverage Δ
src/rocker/nvidia_extension.py 74.38% <31.57%> (-19.60%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 4f9f6d7...21336f9. Read the comment docs.

woensug-choi commented 2 years ago

I've tried with and without nvidia-cuda-dev installation block. Both worked for me. No need to include nvidia-cuda-dev for pre-caching purpose.

tfoote commented 2 years ago

Great thanks for the testing. I cleaned that stanza out of the Dockerfile. And I tweaked the name to reflect that it's just Cuda now not cuda-dev. And I tried a fix for the test to get it to pass on presumably non-nvidia hardware in CI.

woensug-choi commented 2 years ago

https://github.com/osrf/rocker/pull/126/commits/817461e5a4320c5322339ced51f329fc7de194db includes all that I needed. Now, the image has nvcc and all other bin files for the development environment of the Cuda library. Tested with the multibeam sonar https://field-robotics-lab.github.io/dave.doc/contents/dave_sensors/Multibeam-Forward-Looking-Sonar/

woensug-choi commented 1 year ago

Something happend??? I don't see cuda flag in main branch anymore...