search

osrf / rocker

A tool to run docker containers with overlays and convenient options for things like GUIs etc.
Apache License 2.0
555 stars 70 forks source link

Re-add Cuda Devel environment #210

Closed woensug-choi closed 1 year ago

woensug-choi commented 1 year ago

Not sure how but the cuda support is removed at the latest main branch. It was merged before at https://github.com/osrf/rocker/pull/126. Now gone.. Adding back what is missing.

tfoote commented 1 year ago

Wow, thanks for catching that. That PR was old enough that it targeted the old development branch master instead of main which is where we develop now. And we have automation to keep master mirroring main so I think the next merge to main mirrored and shadowed that merge.

woensug-choi commented 1 year ago

I can't miss it. I am using it every time.

woensug-choi commented 1 year ago

Maybe --exclude test_cuda option is required at .github/workflows/basic-ci.yaml

What was in the https://github.com/osrf/rocker/pull/126

        run: nosetests -s -v --with-coverage --cover-package rocker --exclude test_nvidia_glmark2 --exclude test_cuda
tfoote commented 1 year ago

We switched to pytest the tests need to be marked using the pytest method. I think I just did that in https://github.com/osrf/rocker/pull/210/commits/4e418f78115e18a71581c2b285a5c3e05ccfac42