search

osrf / rocker

A tool to run docker containers with overlays and convenient options for things like GUIs etc.
Apache License 2.0
555 stars 70 forks source link

CI is broken #225

Closed tfoote closed 1 year ago

tfoote commented 1 year ago

github appears to have moved the action runners forward. They've dropped node 12 support which it appears checkout@v2 is using and Docker daemon is no longer installed by defaut.

BabaYaga1221 commented 1 year ago

I think in the file .github/workflows/basic-ci.yaml, we need to update ubuntu to 22.04 to 20.04 because we need an earlier version of Ubuntu that supports Node.js 12 and includes Docker daemon by default.. I don't have much knowledge about yaml files but I think this might causing the issue.

tfoote commented 1 year ago

Yeah, the Node.js 12 deprecation was just finalized and support removed it seems. I've switched to checkout@v3 and setup-python@v4

Those were the first issues and are resolved.

But now there's an issue it seems in the new urllib3 version blocking connecting to the docker daemon. I thought it was that docker wasn't installed or running. But then I found:

https://github.com/docker/docker-py/issues/3113

When they upgraded the base image it probably got dependencies refreshed.

I'm trying to debug in branch: https://github.com/osrf/rocker/tree/fix_ci