search

osrf / rocker

A tool to run docker containers with overlays and convenient options for things like GUIs etc.
Apache License 2.0
555 stars 70 forks source link

Resolving issue #153 for hostname #226

Closed BabaYaga1221 closed 1 year ago

BabaYaga1221 commented 1 year ago

The code for the Hostname extension in rocker/extensions.py appears to be well-structured and follows the same pattern as the Name extension, effectively adding a --hostname argument and setting the hostname run arguments for the container. Fixes #153 @tfoote

tfoote commented 1 year ago

Fixes #153

FYI Please use the reference in the body so that github auto links it.

Also please note that CI appear to have been broken today due to the actions being deprecated #225

BabaYaga1221 commented 1 year ago

Thanks for the heads up. I'll make sure to include the reference in the body of my future pull requests. Also, I appreciate you letting me know about the issue with the CI. Do you know if there is a plan to resolve this soon?

tfoote commented 1 year ago

CI should be resolved now. Could you try rebasing your two PRs?

BabaYaga1221 commented 1 year ago

Sure