search

osrf / rocker

A tool to run docker containers with overlays and convenient options for things like GUIs etc.
Apache License 2.0
584 stars 75 forks source link

Resolving issue - #35 - Error display when docker-build perform #227

Open BabaYaga1221 opened 1 year ago

BabaYaga1221 commented 1 year ago

The issue of suppressed output when encountering build errors in the docker_build function has been resolved by modifying the code to handle errors by capturing and printing the output message instead of suppressing it. The modified code now allows users to see the full error message and easily diagnose the issue. Fixes #35 @tfoote

BabaYaga1221 commented 1 year ago

@tfoote Would you like to review the code to see if the build errors can be traced back more clearly?

BabaYaga1221 commented 1 year ago

hi @tfoote, I apologize for being inactive on this PR, but, can you please help with what should I change? The last time when I work on it, I only ended only one solution that I should manually describe the error and provide particular steps to resolve it.

tfoote commented 1 year ago

You need to catch the underlying build error output. And then present what was attempted as well as the error output for the user to understand what failed so they can then fix the problem themselves.