search

osrf / rocker

A tool to run docker containers with overlays and convenient options for things like GUIs etc.
Apache License 2.0
584 stars 75 forks source link

Separate out pre and post user snippets. #243

Closed tfoote closed 1 year ago

tfoote commented 1 year ago

Regular snippets can assume root access. Post snippets can assume USER is set to the final user.

To remove special logic needed in #242

I had thought that this would resolve #130 however the assumption in #37 "arguments are order independent as far as I know as long as they're escaped properly." Environment variables are order dependent.

I think that the solution for that is likely to encourage plugins to set ENV values via snippet versus command line. Though that also has runtime vs build time implications.

Todos

tfoote commented 1 year ago

Merge with #242 This adds the user resolution that was simplified out of that one.