search

osrf / rocker

A tool to run docker containers with overlays and convenient options for things like GUIs etc.
Apache License 2.0
567 stars 74 forks source link

Add indirection for changes in empy 3 vs 4 #261

Closed tfoote closed 10 months ago

tfoote commented 10 months ago

It adds a helper function to provide the indirection across the breaking change.

Fixes #259

tfoote commented 10 months ago

Validated in https://github.com/osrf/rocker/issues/259#issuecomment-1841083289

miguelprada commented 9 months ago

empy has been updated to 4.0.1 which apparently fixes the backward compatibility problem 4.0.0 introduced. Just found out while failing to reproduce issues a colleague was having with my extensions and empy.

Just FYI, in case you prefer to revert this and possibly exclude the "buggy" 4.0.0 version of empy in the requirements.