osrf / ros2_serial_example

61 stars 14 forks source link

Add in tests for the ring buffer implementation #31

Closed clalancette closed 5 years ago

clalancette commented 5 years ago

And while we are at it, fix the ring buffer to be much more understandable. Things done in here:

  1. Split the ring buffer into a separate source file and library (commit 2b65ab4).
  2. Write tests for the ring buffer, testing out various aspects. Along the way, figured out that the previous implementation was very difficult to understand (and possibly buggy), so clean up the ring buffer to be much easier to understand, and add the tests to ensure it stays that way.
  3. Add in documentation for the ring buffer.