osrf / ros2_serial_example

70 stars 15 forks source link

More clang-tidy fixes. #36

Closed clalancette closed 5 years ago

clalancette commented 5 years ago
  1. Make sure to add deleted move, copy, and assignment constructors for Publisher class
  2. Pass a transporter pointer (not the shared_ptr) into the functions; this avoids a copy of the shared_ptr structure
  3. Change the generated code to put the map of topic types to function pointers in an in-class map instead of a static one that could throw an exception we can't catch

Signed-off-by: Chris Lalancette clalancette@openrobotics.org