search

osrf / ros2_serial_example

61 stars 13 forks source link

Make the serial bridge composable #77

Closed ahcorde closed 4 years ago

ahcorde commented 4 years ago

linked to this issue https://github.com/osrf/ros2_serial_example/issues/76

ahcorde commented 4 years ago

Thanks for your commets @mjcarroll

I have reviewed this issue https://github.com/ros2/rclcpp/issues/715. And I had to add a new yaml file to be able to add all the parameters to the composition node.

I think I resolved all of your comments of the CMakeLists.txt