search

osrf / rosbook

Example code to accompany the book Programming Robots with ROS
Apache License 2.0
477 stars 238 forks source link

[Text improvement] Chapter 3: Differing arguments to find_package() call #18

Closed gbiggs closed 7 years ago

gbiggs commented 8 years ago

On page 42, the find_package() call arguments do not match what catkin generates for a Python node. It only adds rospy, not roscpp (since we are creating a Python-only package). Also std_msgs was not added earlier when the dependency was added to the package.xml file. This is confusing for the reader.

gerkey commented 7 years ago

I updated to use your version of the examples and updated the book text to include from there directly, to avoid disagreement. Fixed in reprint.

gbiggs commented 7 years ago

Do you want me to make a tag?