Use new ros3djs with CBOR PointCloud2

osrf / rvizweb

RVizWeb: RViz on the browser

285 stars 59 forks source link

Use new ros3djs with CBOR PointCloud2 #12

Closed mvollrath closed 5 years ago

mvollrath commented 5 years ago

Point to a chain of forks that results in latest roslibjs and ros3djs. Since this chain of forks is not ideal, we should work to get all of the affected packages released and bowers updated:

roslibjs
ros3djs
ros-websocket
ros-service
polymer-ros-rviz

chapulina commented 5 years ago

@mvollrath , mind keeping a list of all upstream PRs that need to be merged so this change can be reverted? The list can either stay on this PR or in a new issue in this repository.

mvollrath commented 5 years ago

~~Upstream things:~~ List moved to #13

mvollrath commented 5 years ago

Added links to relevant PRs on the list.

mvollrath commented 5 years ago

Moved the list to #13 so we can merge this and keep working.

jubeira commented 5 years ago

Just for the record, I tested the pointclouds and it seems to work well with the new cbor encoding :+1:.

Some observations:

When I open the page in the browser I get a JS error in the console coming from scripts/STLLoader: TypeError: THREE.EventDispatcher.prototype.apply is not a function. Perhaps STL and Collada loaders have to be updated as well? These seem to be duplicates of the files that are in ros3djs repo.
Another thing I did notice is that there seems to be an issue with robot models; this is how I see PR2: perhaps this is related to the loaders as well. I don't see any JS error when I load it, just a bunch of logs.

mvollrath commented 5 years ago

Updated this PR to use the proposed ros3djs 1.0.0 with THREE r89 branch.

PointCloud2 show/hide is broken, due to a ros3djs interface change.

jubeira commented 5 years ago

Now that all the dependencies and upgrades are already merged in ros-rviz, ros-websocket and ros-service, we can just keep pointing to master.

Thanks @mvollrath!