osrf / vorc-events

Repository containing team submissions for VORC events.
Apache License 2.0
1 stars 16 forks source link

Team TheItalianJob phase II submission #18

Closed glpuga closed 3 years ago

glpuga commented 3 years ago

The image repo is private but I added virtualrobotx as a collaborator. Let me know if that does not work.

Thanks!

caguero commented 3 years ago

@glpuga , thanks for your submission. As part of the submission process, we do a few checks to help you confirm that your submission is correct. Here are the results:

Task Result Notes
Docker accessible 🟢
stationkeeping 🟢
wayfinding 🟢
perception 🟢
gymkhana 🟡 In the obstacle course the vessel doesn't seem to go into the direction of the acoustic pinger

Legend: 🟢: The behavior looks reasonable. 🟡: The vessel shows activity but not necessary reasonable. 🔴: The vessel doesn't show any activity.

Please, let us know if you plan to tweak your submission or you're happy with it as it is.

glpuga commented 3 years ago

Thanks @caguero , I'll try to debug the issue later today. I'll let you know before the deadline if I can provide and updated version.

glpuga commented 3 years ago

Hi @caguero ! After looking into this I found that there are indeed some issues in my code that I would not be able to fix in time for the deadline, so I will not replace my current submission.

I did, however, notice some strange things while running my submission against most up to date commit of the vorc branch in https://github.com/osrf/vrx-docker :

<xacro:stationkeeping lat="21.31099" lon="-157.88870" namespace="cora" heading="3" competition="vorc" >

<waypoints> <waypoint> <pose>21.31060 -157.88896 3</pose> </waypoint> <waypoint> <pose>21.31122 -157.88997 3.7</pose> </waypoint> <waypoint> <pose>21.31094 -157.89100 6</pose> </waypoint> <waypoint> <pose>21.31065 -157.88985 1</pose> </waypoint> <waypoint> <pose>21.31187 -157.88915 2</pose> </waypoint> </waypoints>

Regarding the note "In the obstacle course the vessel doesn't seem to go into the direction of the acoustic pinger" in the first comment above,

I did not create issues for these observations because I might be misinterpreting the vrx-docker tool configuration files and/or task scores, or there might be some other issue with my build. I'm just letting you know in case you think it's worth looking into this.

mabelzhang commented 3 years ago

the generated xacros for runs 1 and 2 are pointed at Hawaii

Poking in, not hijacking thread, just responding in case others don't remember the status of this part. What you're seeing for runs 1 and 2 is actually expected. We only changed the numbers for run 0 in all the example tasks in vrx-docker. We intended to update runs > 0 to VORC coordinates but haven't done it yet (they still have TODO tags). For the actual competition, we will be using valid coordinates (I double-checked, thanks for reporting!). The error is also larger because it's squared.

glpuga commented 3 years ago

the generated xacros for runs 1 and 2 are pointed at Hawaii

Poking in, not hijacking thread, just responding in case others don't remember the status of this part. What you're seeing for runs 1 and 2 is actually expected. We only changed the numbers for run 0 in all the example tasks in vrx-docker. We intended to update runs > 0 to VORC coordinates but haven't done it yet (they still have TODO tags). For the actual competition, we will be using valid coordinates (I double-checked, thanks for reporting!). The error is also larger because it's squared.

Thanks for the clarification @mabelzhang !

caguero commented 3 years ago

Submission reviewed; feedback provided to Team TheItalianJob. Team responded that they will proceed with latest submission as-is.