osrf / vorc

Virtual Ocean Robot Challenge (VORC) resources
Apache License 2.0
38 stars 11 forks source link

Converted wayfinding task example for VORC cora model and marina world #18

Closed crvogt closed 4 years ago

crvogt commented 4 years ago

Changed the starting point of cora model to match that of perception_task.

Adjusted one of the waypoints from the VRX version to fit the marina world.

Other changes reflected in pull request #17

mabelzhang commented 4 years ago

Code looks good. Thanks!

Could you add some steps for how to test this? I can see the error changing as I move the boat but I don't know which direction is the goal looking at the lat long. Is the red marker supposed to be on the vehicle at startup? Seems different from the station-keeping task where the red marker marks the goal. I can see that is the case in VRX too but just wondering.

Maybe @caguero could test this out faster since he's more familiar with the task. This has already been merged to master but needs testing.

mabelzhang commented 4 years ago

Reopening for visibility so that we know it needs to be tested

mabelzhang commented 4 years ago

Hmm now it shows conflicts. I'll leave it closed so we aren't confused.