osrf / vrx

Virtual RobotX (VRX) resources.
Apache License 2.0
390 stars 180 forks source link

Problem with renaming model_name #638

Closed Grigoriy0526 closed 11 months ago

Grigoriy0526 commented 1 year ago

Hello, I have a problem when starting the sydney_regatta world, if I rename model_name in the file competition.launch.py from 'wamv' to something else, an error occurs, what can such an error be related to? Снимок экрана от 2023-05-10 13-38-42 Снимок экрана от 2023-05-10 12-26-14

carvee1 commented 1 year ago

I solved the bug yesterday, when spawning a vehicle with another name, the problem can be found in the vrx_urdf/wamv_gazebo/urdf/wamv_gazebo.urdf.xacro file. In line 103, you have to change <child>wamv/base_link</child> into <child>$(arg namespace)/base_link</child> Afterwards it should work fine. I already started the pull request #644 to solve this problem Tested in ROS2 Humble and Ubuntu 22.04

M1chaelM commented 11 months ago

Thanks @Grigoriy0526 and @carvee1 for finding and fixing this! Resolved with #644