search

osrf / vrx

Virtual RobotX (VRX) resources.
Apache License 2.0
390 stars 180 forks source link

Set Waves to a Non-zero steepness #650

Closed M1chaelM closed 1 year ago

M1chaelM commented 1 year ago

Our wave model uses trochoidal waves but we currently have the steepness set to zero in all worlds, which collapses the shape to a sinusoid. If possible we should update this value to something that makes the trochoidal shape a little more evident.

M1chaelM commented 1 year ago

Per discussion in #674 it seems that updating the steepness does not have any discernible effect on the wave rendering, and no one is sure why this is the case. Consequently, we don't need to update the values right now, and I will close this issue. Since this situation isn't urgent but also not ideal, I'll make a new issue to document the problem.