osrf / vrx

Virtual RobotX (VRX) resources.
Apache License 2.0
390 stars 180 forks source link

New version of testing tutorial #654

Closed M1chaelM closed 1 year ago

j-herman commented 1 year ago

Review comments for testing tutorial:

M1chaelM commented 1 year ago
  • More of a question than a bug - should the Gazebo GUI open when we run run_trial.bash? I seem to remember that it did not, in VRX classic. It did open in this review, and showed the same behavior as the replay but with markers visible.

@j-herman You're right--in VRX classic it ran without the GUI, so you had to use the replay function to see what happened. In gazebosim, the name of the argument changed, which broke this behavior. I fixed the argument name, but decided that having it show the GUI by default is actually better for most users. When we run the actual competition we can turn off the gui.