osrf / vrx

Virtual RobotX (VRX) resources.
Apache License 2.0
421 stars 189 forks source link

Upstream changes broke the `test-humble-garden` CI workflow #659

Closed M1chaelM closed 1 year ago

M1chaelM commented 1 year ago

Upstream changes to ros_gz added a dependency that breaks our build. See discussion in #658. In addition, the github action checkout v2.4 has been deprecated due to deprecation of node12, so this needs to be upgraded to v3.0. Unfortunately, 3.0 does not support Dockerfiles that run as non-root users (and in general github actions do not support this), so it is incompatible with our test image.

M1chaelM commented 1 year ago

CI has been restored by adding the missing dependency to the test image and by #658, which upgrades our workflow to use checkout v3, and overrides the user to run as root.

Two further changes would improve our CI:

M1chaelM commented 1 year ago

663 switches over to using debs, so changes in dependencies should now be handled for us automatically. This issue is therefore hereby resolved.