search

osrf / vrx

Virtual RobotX (VRX) resources.
Apache License 2.0
390 stars 180 forks source link

#650 issue: updated all the steepness values to 1 #673

Closed hashoak closed 1 year ago

hashoak commented 1 year ago

Have changed all the steepness values to 1 as said in the comments for the variable steepness => "Control the wave steepness. 0 is sine waves, 1 is Gerstner waves."

M1chaelM commented 1 year ago

Thanks for this contribution! My apologies, but I'm afraid the issue you addressed was a bit underspecified--we were discussing it internally and I didn't expect a community member to take it on so quickly. In attempting to test it, we discovered another issue with steepness that is causing us to postpone changes to this value for now. I've written this up in issue #683 (which I hope is more clear than what I wrote for #650).If you're interested in digging into this, we'd certainly welcome help investigating!

In the meantime I will close this PR since I don't anticipate wanting to set all steepness values to 1.