osrf / vrx

Virtual RobotX (VRX) resources.
Apache License 2.0
389 stars 178 forks source link

Steepness has no effect on rendering of the wave field #683

Open M1chaelM opened 1 year ago

M1chaelM commented 1 year ago

Describe the bug See issue #650. Changing the steepness has no discernible effect on the visualization and we're not sure why. This may not be a bug, but it would be good to understand what's going on.

Expected behavior I expect that changing to steepness of the waves to a value closer to 1 would make the waves look more trochoidal and less sinusoidal.

To Reproduce List the steps to reproduce the problem:

  1. Edit sydney_regatta.sdf to change steepness to 0.9:
    params {
     key: "steepness"
       value {
         type: DOUBLE
           double_value: 0.9
        }
     }
    }
  2. Next, run 'ros2 launch vrx_gz competition.launch.py world:=sydney_regatta'
  3. Note that the shape of the waves stays the same.

System Configuration: Tell us about your system.