osrf / vrx

Virtual RobotX (VRX) resources.
Apache License 2.0
389 stars 178 forks source link

add debug option to wind publishers #687

Closed j-herman closed 10 months ago

j-herman commented 1 year ago

We will not want to publish the wind speed and direction during the actual competition events. Some options for enabling/disabling these topics, in order of difficulty of implementation, are:

This PR implements the first option. To test, add the tag to a world file, launch vrx with that world, and observe that no data is published to /vrx/debug/wind/direction or /vrx/debug/wind/speed.

For example:

tejalbarnwal commented 1 year ago

Hey, I tested it out. It works flawlessly!

j-herman commented 1 year ago

@tejalbarnwal Thank you for the review! I'm going to hold this until we figure out the implementation for competition mode as we may want to change the method.

j-herman commented 11 months ago

@caguero Just confirming we don't need this before I close it - fully covered by the competition mode PR?

caguero commented 11 months ago

@caguero Just confirming we don't need this before I close it - fully covered by the competition mode PR?

Yeah, feel free to close it. We should be able to do it by isolating all Gazebo topics and only let the ROS 2 topics go through the competitors image.