osrf / vrx

Virtual RobotX (VRX) resources.
Apache License 2.0
389 stars 178 forks source link

Update VRX Docker MWE tutorial for 2023 #719

Closed M1chaelM closed 10 months ago

M1chaelM commented 10 months ago

The tutorial for minimal working examples of competitor Docker images needs to be updated to include the 2023 image: https://github.com/osrf/vrx/wiki/tutorials-vrx_docker_mwes

M1chaelM commented 10 months ago

Following our offline discussion yesterday, my preferred way to update this tutorial is as follows:

This will mean our starter image example is slightly fancier than the image a team would produce by just following the tutorial, but I think that's Ok. Another option suggested by @caguero would be to create a vrx_2023_simple folder in vrx-docker and add the files needed.

@caguero are you ok with the first option?

caguero commented 10 months ago

Thanks for the context, I'm totally OK with the first suggested option.

M1chaelM commented 10 months ago

@caguero I went through to make these changes and realized I had forgotten why we had 2 images in 2022. The simple image is already a bit more advanced than what the teams would produce in a tutorial. We added the "starter" image because many teams were having trouble understanding how to compile a ROS workspace on their Docker image, and some of them were trying to do it at runtime.

I'm not sure whether all teams will want to build VRX on the competitor image, so maybe we need two examples after all...

caguero commented 10 months ago

Updated in https://github.com/osrf/vrx-docker/pull/72