search

osrf / vrx

Virtual RobotX (VRX) resources.
Apache License 2.0
387 stars 178 forks source link

Fix score in follow-the-path task #748

Closed caguero closed 8 months ago

caguero commented 8 months ago

While running phase 2 I noticed an issue in the scoring of the follow-the-path task.

If the course isn't completed, the score is overwritten with the timeout score, that was initialized to 200. Now that the task grants points each time the vehicles crosses a gate, we shouldn't do anything special if the task timeouts. The score should be preserved.

How to test it?

Launch a follow-the-path task:

ros2 launch vrx_gz competition.launch.py world:=practice_2023_follow_path0_task

And then:

ros2 topic echo /vrx/task/info

If you don't cross any gates, the score should be 0 instead of 200.

j-herman commented 8 months ago

I've reviewed this and it's working fine, but for some reason the button to submit the approval is hanging up. I'll try again later, but no need for anyone else to test this.

caguero commented 8 months ago

I've reviewed this and it's working fine, but for some reason the button to submit the approval is hanging up. I'll try again later, but no need for anyone else to test this.

Thanks! Merging then.