search

osrg / gobgp

BGP implemented in the Go Programming Language
https://osrg.github.io/gobgp/
Apache License 2.0
3.59k stars 684 forks source link

SetLargeCommunityMethod does not have 'large-community-set-ref' #1985

Open emil-palm opened 5 years ago

emil-palm commented 5 years ago

I think this might be a just a oversight but SetLargeCommunityMethod struct does not have a 'large-community-set-ref' as the other version has: https://github.com/osrg/gobgp/blob/master/internal/pkg/config/bgp_configs.go#L5039

vs

https://github.com/osrg/gobgp/blob/master/internal/pkg/config/bgp_configs.go#L5148 and https://github.com/osrg/gobgp/blob/master/internal/pkg/config/bgp_configs.go#L5084

Should be a simple fix

fujita commented 5 years ago

Looks like an oversight. Updating gobgp.yang and adding such is fine by me but *community-set-ref isn't used by any code.