send-max: respect configuration

osrg / gobgp

BGP implemented in the Go Programming Language

https://osrg.github.io/gobgp/

Apache License 2.0

3.66k stars 699 forks source link

send-max: respect configuration #2783

Closed maxime-peim closed 7 months ago

maxime-peim commented 8 months ago

send first SendMax routes for a given prefix to neighbors
when route withdrawal, send the next filtered route
add a local identifier to a path (rf:prefix:local id)
register which paths are filtered per peer

maxime-peim commented 8 months ago

Hi @fujita I was not able to run zapi test locally, will it be possible to run the CI please?

fujita commented 8 months ago

I've just run the CI. btw, you can run the CI by forking the gobgp repository and creating a pull request for your repository.

maxime-peim commented 8 months ago

Thanks! This is what I have done, but the CI does not seem to be triggered when force-pushing

maxime-peim commented 8 months ago

Sorry, it should be good now. However, I didn't find a way to re-run the CI from my side apart from closing and reopening the PR...

maxime-peim commented 7 months ago

Hi @fujita @bayrinat, Do you have comments to do on that PR, please?

maxime-peim commented 7 months ago

Anyone?

fujita commented 7 months ago

Thanks a lot for working the feature! So each peer needs to keep filtered paths in memory. looks like it could consume lots of memory in some configurations. Any other way to implement that feature?

maxime-peim commented 7 months ago

Thanks a lot for working the feature! So each peer needs to keep filtered paths in memory. looks like it could consume lots of memory in some configurations. Any other way to implement that feature?

Hi @fujita, Each peer keeps a key to the path that is stored in the local RIB, it does not have a copy of the path. Maybe we could only store N filtered paths if the limit is set to N. So, we could replace all the advertised paths are withdrawn at once.

fujita commented 7 months ago

Thanks a lot!