osrg / gobgp

BGP implemented in the Go Programming Language
https://osrg.github.io/gobgp/
Apache License 2.0
3.66k stars 699 forks source link

graceful restart: send initial paths list to all neighbors #2803

Closed hardeker closed 6 months ago

hardeker commented 6 months ago

Before this PR, when graceful restart was configured for a neighbor and when the restart flag was set by the restarting speaker, if the neighbor was not advertising the GR capability, the initial paths list was never sent by the restarting speaker to its neighbor

This is a problem when the server is configured with graceful restart for all its peers without knowing if the peer supports it. If some of the peers don't support it, they may never receive the routes from the restarting speaker, leading to an inconsistent routing state.

@fujita, I closed previous PR #2794 and re-created this new one with some modification based on the discussion there

fujita commented 6 months ago

Thanks a lot!